Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data loss when form that has running auto submits in it is submitted #1164

Open
cornae opened this issue May 17, 2023 · 1 comment
Open

Data loss when form that has running auto submits in it is submitted #1164

cornae opened this issue May 17, 2023 · 1 comment
Assignees

Comments

@cornae
Copy link
Member

cornae commented May 17, 2023

Consider a form with an autosubmit subform inside of it. The user makes a change within the subform. There's a delay set of 3 seconds. Within those 3 seconds the user clicks on the submit button of the entire form, return to the view and establishes that the last edited content within the subform is lost.

Would it be a good idea to cancel all subform auto submits once a manual submit for the entire form is fired?

@pilz
Copy link
Member

pilz commented May 17, 2023

This is a symptom of a larger problem. It is e.g. also possible that you upload a file and make a change and the order of the subforms are reversed, then we have data loss. And it also hooks into two people having the same item open. Lots of potential conflicts here, we just survive because it doesn't happen too often.

Also in the above scenario, submitting the whole form should have submitted the changes in the subform as well, so they should not have been lost. More investigation is needed.

This is just to mark that we must have a larger discussion if we want to fix it and that making a small patch is unlikely to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants