Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write.configs.ed should error if revision not specified #3142

Closed
infotroph opened this issue Mar 21, 2023 · 0 comments · Fixed by #3156
Closed

write.configs.ed should error if revision not specified #3142

infotroph opened this issue Mar 21, 2023 · 0 comments · Fixed by #3156

Comments

@infotroph
Copy link
Member

infotroph commented Mar 21, 2023

I understand the logic of this bit, and I know you didn't add the line @Aariq, but I wonder if it would be better for the code to throw an error if the revision isn't specified. In general we're trying to reduce/isolate the dependency of pecan modules and functions on the database -- by fixing this one error-checking line we're making users of the ED2 module install the database.

Originally posted by @mdietze in #3135 (comment)

☝️ In reference to the following line of code in models/ed/write_configs.ed.R:

 model <- PEcAn.DB::db.query(paste("SELECT * FROM models WHERE id =", settings$model$id), params = settings$database$bety)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants