Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PabloCastellano
Copy link

@PabloCastellano PabloCastellano commented Mar 16, 2022

Supersedes #121, #116, #45

Fixes #111, #133 and #146

@pors
Copy link
Collaborator

pors commented Mar 16, 2022

I would love to have this one solved, but I would like to hear @PedroBern 's opinion on it first.

@PabloCastellano how can I test this best?

@PabloCastellano
Copy link
Author

@pors Try it:

git clone -b update-dependencies https://github.com/PabloCastellano/django-graphql-auth2
cd django-graphql-auth2
pip install -e .

@pors
Copy link
Collaborator

pors commented Apr 17, 2022

I can't get it to work for Django 4 (which is the only reason for me to upgrade django-graphql-jwt>=0.3.2). It does work for 0.3.1, but that doesn't work with Django 4. Sorry, but I think it is best to abandon this project and find an alternative.

@eikebartels
Copy link

for me this branch works with
-django==4.0.5

  • django-graphql-jwt==0.3.4

@pors
Copy link
Collaborator

pors commented Jun 25, 2022

I still think this PR will break things for people. See #23. It doesn't say there what the actual incompatibility is though. Can someone help out there? @joshuachinemezu @PedroBern @ulgens @panosangelopoulos ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version conflict with django-graphql-jwt
3 participants