Add auxiliary API for Proxy

Author: Vitalii Arteev

src/ipc/ipc-common/CMakeLists.txt

@@ -23,6 +23,7 @@ facelift_add_library(FaceliftIPCCommonLib
         IPCServiceAdapterBase.h
         NewIPCServiceAdapterBase.h
         IPCAttachedPropertyFactory.h
+        observer.h
     HEADERS_NO_MOC
         AppendDBUSSignatureFunction.h
         ipc-serialization.h

src/ipc/ipc-common/IPCProxyBase.h

@@ -33,7 +33,7 @@
 #include "ipc-common.h"
 #include "IPCProxyBaseBase.h"
 #include "IPCProxyBinderBase.h"
-
+#include "observer.h"
 
 #if defined(FaceliftIPCCommonLib_LIBRARY)
 #  define FaceliftIPCCommonLib_EXPORT Q_DECL_EXPORT
@@ -49,10 +49,12 @@ class IPCProxyBase : public AdapterType, protected IPCProxyBaseBase
 
 public:
     using InterfaceType = AdapterType;
+    IsReadyObserver m_readyObserver{};
 
 public:
     IPCProxyBase(QObject *parent) : AdapterType(parent)
     {
+        QObject::connect(this, &InterfaceBase::readyChanged, &m_readyObserver, &IsReadyObserver::onReadyChanged);
     }
 
     template<typename BinderType>

src/ipc/ipc-common/observer.h

@@ -0,0 +1,108 @@
+/**********************************************************************
+**
+** Copyright (C) 2020 Luxoft Sweden AB
+**
+** This file is part of the FaceLift project
+**
+** Permission is hereby granted, freIPCServiceAdapterBasee of charge, to any person
+** obtaining a copy of this software and associated documentation files
+** (the "Software"), to deal in the Software without restriction,
+** including without limitation the rights to use, copy, modify, merge,
+** publish, distribute, sublicense, and/or sell copies of the Software,
+** and to permit persons to whom the Software is furnished to do so,
+** subject to the following conditions:
+**
+** The above copyright notice and this permission notice shall be
+** included in all copies or substantial portions of the Software.
+**
+** THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+** EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+** MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+** NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
+** BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
+** ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+** CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+** SOFTWARE.
+**
+** SPDX-License-Identifier: MIT
+**
+**********************************************************************/
+
+#pragma once
+
+#include <memory>
+#include <QVector>
+#include <QObject>
+
+namespace facelift {
+
+class IObserver : public QObject
+{
+    Q_OBJECT
+public:
+    virtual void onReadyChanged(std::shared_ptr<QMetaObject::Connection> connection) = 0;
+};
+
+class IsReadyObserver: public QObject
+{
+    Q_OBJECT
+    QVector<IObserver *> m_observers{};
+
+public:
+    IsReadyObserver() {}
+
+    // Set observers
+    void setObservers(const QVector<IObserver *> &observers) {
+        m_observers = observers;
+        for(auto observer: observers){
+            auto connection = std::make_shared<QMetaObject::Connection>();
+            *connection = QObject::connect(this, &IsReadyObserver::readyChanged, observer, [observer, connection](){
+                observer->onReadyChanged( connection );
+            });
+         }
+    }
+
+    // Get observers
+    const QVector<IObserver *> &getObservers() const {
+        return m_observers;
+    }
+
+    Q_SIGNAL void readyChanged();
+
+    void onReadyChanged() {
+        emit readyChanged();
+    }
+};
+
+// Single-time observer which will unregister itself when done
+template<typename T>
+class SingleTimeObserver : public IObserver
+{
+    T m_function;
+
+public:
+    explicit SingleTimeObserver(T function) : m_function{function} {}
+    ~SingleTimeObserver() = default;
+
+    void onReadyChanged(std::shared_ptr<QMetaObject::Connection> connection) override {
+        m_function();
+        QObject::disconnect(*connection);
+    }
+};
+
+// Standard observer which will work for each signal
+template<typename T>
+class StandartObserver : public IObserver
+{
+    T m_function;
+
+public:
+    explicit StandartObserver(T function) : m_function{function} {}
+    ~StandartObserver() = default;
+
+    void onReadyChanged(std::shared_ptr<QMetaObject::Connection>  ) override {
+        m_function();
+    }
+};
+
+}

tests/unittest/CMakeLists.txt

@@ -6,18 +6,34 @@ if(${GTEST_FOUND})
         add_library(GTest::GMock UNKNOWN IMPORTED)
         set_target_properties(GTest::GMock PROPERTIES IMPORTED_LOCATION ${GMOCK_LIBRARY})
     else()
-        message(WARNING "Google test/mock not found.")
+        message(ERROR "Google test/mock not found.")
     endif()
 
+    find_package(Qt5 COMPONENTS Test REQUIRED)
+    if(${QT5TEST_NOTFOUND})
+        message(ERROR "Required package Qt5Test not found.")
+    endif()
     find_package(Threads REQUIRED)
-    set(FACELIFT_GTEST_LIBRARIES ${GTEST_BOTH_LIBRARIES} GTest::GMock Threads::Threads)
+    if(${THREADS_NOTFOUND})
+        message(ERROR "Required package Threads not found.")
+    endif()
+    set(FACELIFT_GTEST_LIBRARIES ${GTEST_BOTH_LIBRARIES} GTest::GMock Qt5::Test Threads::Threads)
     include_directories(${GTEST_INCLUDE_DIRS})
 
     facelift_add_test(UnitTests
         SOURCES FaceliftUtilsTest.cpp
-        LINK_LIBRARIES ${FACELIFT_GTEST_LIBRARIES} FaceliftCommonLib)
+        LINK_LIBRARIES
+	${FACELIFT_GTEST_LIBRARIES}
+	FaceliftCommonLib
+    )
 
+    facelift_add_test(UnitTestsObserver
+        SOURCES FaceliftObserverTest.cpp
+        LINK_LIBRARIES
+	${FACELIFT_GTEST_LIBRARIES}
+	FaceliftIPCCommonLib
+    )
 else()
-    message(WARNING "Required package google test not found!")
+    message(ERROR "Required package google test not found!")
 endif()
 

tests/unittest/FaceliftObserverTest.cpp

@@ -0,0 +1,71 @@
+#include <gtest/gtest.h>
+#include "IPCProxyBase.h"
+#include "InterfaceBase.h"
+#include <QSignalSpy>
+
+namespace {
+
+using namespace facelift;
+
+class Counter
+{
+public:
+    Counter() { m_value = 0; }
+
+    void incValue() {
+        ++m_value;
+    }
+    int getValue() const {
+       return m_value;
+    }
+private:
+    int m_value;
+};
+
+class IPCProxyBaseTest : public ::testing::Test
+{
+public:
+    Counter c1;
+    Counter c2;
+    StandartObserver  < std::function<void()> > * obs1 = new StandartObserver  < std::function<void()> > (std::bind(&Counter::incValue, &c1) );
+    SingleTimeObserver< std::function<void()> > * obs2 = new SingleTimeObserver< std::function<void()> > (std::bind(&Counter::incValue, &c2) );
+
+    IPCProxyBase<InterfaceBase> proxyBase{nullptr};
+
+    ~IPCProxyBaseTest() {
+        delete obs1;
+        obs1 = nullptr;
+        delete obs2;
+        obs2 = nullptr;
+    }
+};
+
+TEST_F(IPCProxyBaseTest, testObservers)
+{
+    // Set observers to proxy
+    const auto expected = QVector<IObserver*>{obs1, obs2,};
+    proxyBase.m_readyObserver.setObservers(expected);
+    const auto actual = proxyBase.m_readyObserver.getObservers();
+
+    // Check values before calling a signal
+    ASSERT_EQ(c1.getValue(), 0); // for StandartObserver
+    ASSERT_EQ(c2.getValue(), 0); // for SingleTimeObserver
+
+    // Check handle of signal
+    QSignalSpy spy(&proxyBase.m_readyObserver, &IsReadyObserver::readyChanged );
+    ASSERT_EQ( spy.isValid(), true);
+    spy.clear();
+
+    // Generate signal
+    ASSERT_EQ(spy.count(), 0);
+    proxyBase.readyChanged();
+    proxyBase.readyChanged();
+    proxyBase.readyChanged();
+    ASSERT_EQ(spy.count(), 3);
+
+    // Check values after signal call
+    ASSERT_EQ(c1.getValue(), 3); // for StandartObserver
+    ASSERT_EQ(c2.getValue(), 1); // for SingleTimeObserver
+}
+
+} // end namespace