Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove FSL from dependencies #528

Merged
merged 16 commits into from
Oct 3, 2022
Merged

[REF] Remove FSL from dependencies #528

merged 16 commits into from
Oct 3, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 26, 2022

Closes #524. Related to PennLINC/xcpd_build#2. Also related to #338.

Changes proposed in this pull request

  • Replace calls to fslmerge with nilearn.image.concat_imgs.
  • Replace calls to fslsmooth with nilearn.image.smooth_img.
  • Replace calls to fslmaths with nilearn.image.math_img.

Documentation that should be reviewed

None.

@kahinimehta
Copy link
Collaborator

@tsalo might need to update the smoothing tests to reflect the removal of FSL

@tsalo
Copy link
Member Author

tsalo commented Sep 27, 2022

@kahinimehta done! Just waiting for the Docker image to deploy and then I'll update the Dockerfile.

@tsalo tsalo marked this pull request as ready for review September 27, 2022 17:10
@tsalo tsalo requested a review from kahinimehta September 27, 2022 17:11
@tsalo tsalo merged commit c10a138 into PennLINC:main Oct 3, 2022
@tsalo tsalo deleted the rm-fsl branch October 3, 2022 15:16
@tsalo tsalo added the maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc. label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance. Dependency versions, dependencies, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider dropping FSL dependency
2 participants