tzset

Author: khwilliamson

ext/POSIX/t/time.t

@@ -16,14 +16,15 @@ use Test::More tests => 49;
 # Those with a working tzset() should be able to use the TZ below.
 $ENV{TZ} = "EST5EDT";
 
+# It looks like POSIX.xs claims that only VMS and Mac OS traditional
+# don't have tzset().  Win32 works to call the function, but it doesn't
+# actually do anything.  Cygwin works in some places, but not others.  The
+# other Win32's below are guesses.
+my $has_tzset = $^O ne "VMS" && $^O ne "cygwin"
+             && $^O ne "MSWin32" && $^O ne "interix";
+
 SKIP: {
-    # It looks like POSIX.xs claims that only VMS and Mac OS traditional
-    # don't have tzset().  Win32 works to call the function, but it doesn't
-    # actually do anything.  Cygwin works in some places, but not others.  The
-    # other Win32's below are guesses.
-    skip "No tzset()", 1
-       if $^O eq "VMS" || $^O eq "cygwin" ||
-          $^O eq "MSWin32" || $^O eq "interix";
+    skip "No tzset()", 1 unless $has_tzset;
     tzset();
     SKIP: {
         my @tzname = tzname();
@@ -42,9 +43,7 @@ SKIP: {
 $ENV{TZ} = "UTC0UTC";
 
 SKIP: {
-    skip "No tzset()", 2
-       if $^O eq "VMS" || $^O eq "cygwin" ||
-          $^O eq "MSWin32" || $^O eq "interix";
+    skip "No tzset()", 1 unless $has_tzset;
     tzset();
     my @tzname = tzname();
     like($tzname[0], qr/(GMT|UTC)/i, "tzset() to GMT/UTC");
@@ -237,7 +236,7 @@ SKIP: {   # GH #23878; test that dst fall back works properly
     skip "No mktime()", $skip_count if $Config{d_mktime} ne 'define';
     my $locale = "Europe/Paris";
     $ENV{TZ} = $locale;
-    tzset();
+    tzset() if $has_tzset;
 
     skip "'$locale' not understood", $skip_count
                    if POSIX::strftime("%H", localtime($reference_time)) != 19;
@@ -267,15 +266,17 @@ SKIP: {   # GH #23878: test that dst spring forward works properly; use a
 
     my $locale = "PST8PDT";
     $ENV{TZ} = $locale;
+    tzset() if $has_tzset;
+
     skip "'$locale' not understood", $skip_count if
                 POSIX::strftime("%H", localtime($reference_time)) != 10;
 
     my $t = 1741510800;     # an hour before time should have changed
 
     my @spring = (
-                  [   -1, "2025-03-09 00:59:59-0800", "Chg -1 hr, 1 sec" ],
+                  [   -1, "2025-03-09 00:59:59-0800", "Chg -1 hr,-1 sec" ],
                   [    0, "2025-03-09 01:00:00-0800", "Chg -1 hr, 0 sec" ],
-                  [    1, "2025-03-09 01:00:01-0800", "Chg -59 min, 59 sec" ],
+                  [    1, "2025-03-09 01:00:01-0800", "Chg -59 min,-59 sec" ],
                   [ 3599, "2025-03-09 01:59:59-0800", "Chg -1 sec" ],
                   [ 3600, "2025-03-09 03:00:00-0700",
                                             "At Redmond DST spring forward" ],