More client code quality improvements, removing more unused assets #116
Commits on Aug 16, 2024
-
Client: Rename NOP -> numberOfPlayers
(R)NOP without any context was confusing. The new solution is a bit verbose but at least it's possible to instantly know what it does.
-
Client: Remove static initializer blocks from classes
The code is easier to follow if static final fields are initialized in the same place they are declared.
-
Client: Remove more unused resources and assets
These are mostly related AGolf2, a different game from the classic minigolf. Also included are some old server code relics and assets from other games.
-
Client: More minor code quality improvements
- Use integers instead of chars in math operations - Use more magic constants where possible - Remove more unused imports - Remove useless JavaDocs that just say "Playforia" - Remove some explicit uses of UTF-8 enconding. This is the default encoding since Java 18. - Remove unused LobbyRef class
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.