Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Soft Shutdown custom shell script retries too quickly #105

Open
withoutgettingwet opened this issue Feb 5, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@withoutgettingwet
Copy link
Contributor

Environment

  • Zero 2W
  • Debian Bookworm
  • 1.7.5

To Reproduce

  1. Go to the webui > settings > soft shutdown
  2. Select custom shell
  3. Run a service that takes a few seconds to load, or run any series of commands with a "sleep 10" in there (In my screenshot, longwait.sh is simply "sleep 10 && sudo shutdown now")
  4. Press the power button and watch from journalctl as it retries the command about every 0.5 seconds, locking up the device it is running on. (In my screenshot, it never actually reaches the shutdown command, so I believe it is killing the previous attempt every time)

Expected behavior
The command runs, waiting more than a second or two before killing the running process and retrying it. Ideally, a configurable wait so that the default can be a sane value, but allowing for longer grace periods

Screenshots
image

@withoutgettingwet withoutgettingwet added the bug Something isn't working label Feb 5, 2024
@withoutgettingwet
Copy link
Contributor Author

withoutgettingwet commented Mar 13, 2024

@fengyc I see that there has been a recent commit, but nothing was changed except for the readme.

Is this something that is/will be worked on?

@mighty-sparrow
Copy link

I'm having a similar issue wherein I'm trying to clear an ePaper display prior to shutdown. I'm using a python script to manage the ePaper and the command loops over and over, just like was reported by @seelenamt . Is there a GOOD example of how we should be leveraging the soft shutdown script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants