Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken familylink.google.com page #141

Open
d3m3t3r opened this issue Jun 30, 2023 · 3 comments
Open

Broken familylink.google.com page #141

d3m3t3r opened this issue Jun 30, 2023 · 3 comments

Comments

@d3m3t3r
Copy link

d3m3t3r commented Jun 30, 2023

Selection Search somehow breaks familylink.google.com page which gets stuck on the initial "splash screen" (only the logo, "Family Link" and "Google" is displayed). Adding familylink.google.com (and gstatic.com and googleapis.com) to the blacklist doesn't help. Disabling the addon fixes the page.

Version: 0.8.64
Firefox: 114.0.2 (64-bit)

@Pitmairen
Copy link
Owner

It seems to be caused by these lines:

// FIREFOX-BUG?: In firefox, depending on a sites Content Security Policy header, the
// content must be set to empty strings, before appending to the dom,
// or else firefox logs warnings about blocked inline content.
_defaultStyleNode.textContent = '';
_circularStyleNode.textContent = '';
_customStyleNode.textContent = '';

Removing those lines seems to fix familylink.

I don't remember which sites was affected by the issue that was fixed by those lines, but maybe it has been fixed in new versions of firefox, so maybe it is safe to just remove them. I need to do a bit of testing first.

@Pitmairen
Copy link
Owner

Using the following instead of empty strings seems to fix familylink without breaking other sites.

_defaultStyleNode.textContent = ';';
_circularStyleNode.textContent = ';';
_customStyleNode.textContent = ';';

Pitmairen added a commit that referenced this issue Jul 23, 2023
@Pitmairen
Copy link
Owner

It took a while, but I have release a new version for Firefox now with this fix. It should be available soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants