Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect menu display on https://rutor.info #142

Open
selvios opened this issue Jul 26, 2023 · 1 comment
Open

Incorrect menu display on https://rutor.info #142

selvios opened this issue Jul 26, 2023 · 1 comment

Comments

@selvios
Copy link

selvios commented Jul 26, 2023

Hi,
Thanks for the great extension.
On https://rutor.info, when highlighting and clicking, the menu is constantly displayed at the top.
The gif shows clearly https://file.coffee/u/7pGGFiUAfOjhuO02Cm5nW.gif
This only happens on Firefox

@selvios selvios changed the title Неправильное отображение меню Incorrect menu display on https://rutor.info Jul 26, 2023
@Pitmairen
Copy link
Owner

Looks like this is caused by wrong calculation of the window height, so the extension thinks the popup is opened outside of the browser view and tries to move it to compensate.

The extension is currently using document.documentElement.clientHeight to get the window height. I think this can be replaced by window.innerHeight to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants