Fixes from warning generation in Clang(windows) and MSVC #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8691 |
aaye
force-pushed
the
dev_pr_warnings_0
branch
from
d94ef92 to
2918312
Compare
|
I seem to be hitting the 2-hour limit on the windows compile across my changes. Anything that can be done about that? |
aaye
force-pushed
the
dev_pr_warnings_0
branch
2 times, most recently
from
83efb67 to
9625ddf
Compare
|
We’re looking into it ($$), but don’t expect it will be resolved in the
immediate future.
On Fri, Sep 15, 2023 at 3:49 PM Andrew Aye ***@***.***> wrote:
I seem to be hitting the 2-hour limit on the windows compile across my
changes. Anything that can be done about that?
—
Reply to this email directly, view it on GitHub
<#2677 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPOU2HPHN3ZGAIIPE7A7KDX2TLOFANCNFSM6AAAAAA4VJIXDI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
--spiffiPhone
|
|
Thanks! The rest all got through so not that big of a hit in terms of value for time spent. Will see if there is anything I can do on my end. |
aaye
force-pushed
the
dev_pr_warnings_0
branch
2 times, most recently
from
74591eb to
057f819
Compare
aaye
force-pushed
the
dev_pr_warnings_0
branch
from
057f819 to
ae38e95
Compare
|
Got pinged recently on an issue with PCH on Windows builds etc. I know its been a year, updated my changes to the most recent and updated the branch. |
aaye
force-pushed
the
dev_pr_warnings_0
branch
from
ae38e95 to
0a0820c
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aaye
force-pushed
the
dev_pr_warnings_0
branch
from
0a0820c to
f6315de
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Removed unused member variables Printf format for a size_t should be zu (since the size of the variable is by definition capable of being different integer lengths). Fixed some API tags that were causing a conflict in export/import pairing Added some missing override keywords Added some ARCH_PRAGMA warning disables around some code that was causing Windows Clang (clang version 19.1.3, Target: x86_64-pc-windows-msvc, Thread model: posix) to throw warnings. Fixed windows linked flags when using clang
aaye
force-pushed
the
dev_pr_warnings_0
branch
from
f6315de to
cc0ecda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fixes Issue(s)