-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TfMallocTag.Tls.Find static method on Darwin. #3292
Open
furby-tm
wants to merge
1
commit into
PixarAnimationStudios:dev
Choose a base branch
from
wabiverse:wabi-darwin-fix-tfmalloctag-tls-find
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix TfMallocTag.Tls.Find static method on Darwin. #3292
furby-tm
wants to merge
1
commit into
PixarAnimationStudios:dev
from
wabiverse:wabi-darwin-fix-tfmalloctag-tls-find
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also remove the ARCH_HAS_THREAD_LOCAL preprocessor and any/all conditional compilation checks for this value. Signed-off-by: furby™ <[email protected]>
furby-tm
changed the title
Fix TfMalocTag.Tls.Find() static method on Darwin.
Fix TfMalocTag.Tls.Find static method on Darwin.
Sep 15, 2024
furby-tm
changed the title
Fix TfMalocTag.Tls.Find static method on Darwin.
Fix TfMallocTag.Tls.Find static method on Darwin.
Sep 15, 2024
(cc. @dgovil, @AlexSchwank), I was not able to locate Nicholas Blasingame's GitHub username, but feel free to ping him here to sync up, thanks! |
Filed as internal issue #USD-10127 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
dgovil
added
the
needs review
Issue needing input/review by the repo maintainer (Pixar)
label
Nov 7, 2024
Another one that we talked about on slack but I forgot to respond here. This looks like a good change to me. Thanks for solving that. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original reasoning for disabling this was because originally
thread_local
was not available in Apple's (now ancient) Clang pre-Xcode 8, however now all modern versions of Apple's Clang do have support forthread_local
.Description of Change(s)
TfMallocTag::Tls::Find()
now returns the per-thread data forTfMallocTag
on all Darwin platforms, which before this change, has always returned nothing (and was silently failing).ARCH_HAS_THREAD_LOCAL
preprocessor.ARCH_HAS_THREAD_LOCAL
.Note
I had noticed the following two Tf test cases are failing, but this is unrelated to this revision, as they were failing before this revision was introduced.
Fixes Issue(s)