[BUG] search.rs Uses partial_cmp with unwrap_or for Score Sorting

[xyz080125]

Project

vgrep

Description

In search.rs line 82-85, the sorting uses partial_cmp with unwrap_or(std::cmp::Ordering::Equal). If scores contain NaN values (which can propagate from the embedding engine), this leads to non-deterministic sorting behavior since NaN comparisons return None.

Error Message

Debug Logs

System Information

OS: Any
Rust Version: 1.75+

Screenshots

No response

Steps to Reproduce

1. Cause the embedding engine to produce NaN values (e.g., through numerical overflow)
2. Perform a search
3. Observe the ordering of results across multiple runs

Expected Behavior

Results should be consistently sorted, and NaN scores should be handled explicitly (e.g., placed at the end)

Actual Behavior

Results with NaN scores may appear in random positions due to unstable sorting behavior

Additional Context

No response

[echobt]

Issue validated. The reported problem has been confirmed in the codebase where NaN scores caused unstable sorting. A Pull Request with the fix has been submitted: CortexLM/vgrep#58.