Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging of duplicate files in resourcepack generation #4419

Open
LoneDev6 opened this issue Feb 11, 2025 · 1 comment
Open

Better logging of duplicate files in resourcepack generation #4419

LoneDev6 opened this issue Feb 11, 2025 · 1 comment
Labels
compat: plugin Compatibility with another Spigot plugin type: enhancement Make a feature better.
Milestone

Comments

@LoneDev6
Copy link
Collaborator

LoneDev6 commented Feb 11, 2025

Currently ItemAdder cuts the first part of the path in the warning errors.
This is a bad behaviour because some resourcepack files might have been found in other plugins folders and cause confusion.
The new logging will show the complete path instead.

Example of the new logging for shaders overlapping text effects and emotes:

Found shader overlapping an ItemsAdder Texts shader: plugins/BetterHud/build/assets/minecraft/shaders/core/rendertype_text.json -> shaders/core/rendertype_text.json
Disable text-effects to edit these shaders manually.
[Pack] pre-1.21.2 shader JSON found. Adding 1.21.2+ compatibility. File: plugins/BetterHud/build/assets/minecraft/shaders/core/rendertype_entity_translucent_cull.json
[Pack] pre-1.21.2 shader JSON found. Adding 1.21.2+ compatibility. File: plugins/BetterHud/build/assets/minecraft/shaders/core/rendertype_item_entity_translucent_cull.json
[Pack] pre-1.21.2 shader JSON found. Adding 1.21.2+ compatibility. File: plugins/BetterHud/build/assets/minecraft/shaders/core/rendertype_entity_cutout.json

I also implemented a log to clearly show where the duplicate any duplicate file was found.

Example of the new logging for duplicate files:

Duplicate found. contents/dupl2/resourcepack/minecraft/textures/item/modern_quartz.png -> textures/item/modern_quartz.png
Previous file: contents/dupl1/resourcepack/minecraft/textures/item/modern_quartz.png
@LoneDev6 LoneDev6 converted this from a draft issue Feb 11, 2025
@LoneDev6 LoneDev6 added type: enhancement Make a feature better. compat: plugin Compatibility with another Spigot plugin labels Feb 11, 2025
@LoneDev6 LoneDev6 added this to the 4.0.9 milestone Feb 11, 2025
@LoneDev6 LoneDev6 changed the title Better logging of duplicate files in case of pack merging from other plugins directories Better logging of duplicate files in resourcepack generation Feb 11, 2025
@LoneDev6
Copy link
Collaborator Author

This will help both staff members, me and the customers to get more info about where is the cause of duplicate files issues, which wasn't that easy to find previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat: plugin Compatibility with another Spigot plugin type: enhancement Make a feature better.
Projects
Status: Done
Development

No branches or pull requests

1 participant