Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

fix(rds): allowing a no name rds #1094

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(rds): allowing a no name rds #1094

merged 1 commit into from
Nov 28, 2023

Conversation

bassrock
Copy link
Member

Goal

Allow no name to be passed to RDS so that we can upgrade Feature Flags to latest terraform. Without this terraform tries to replace the database.

@bassrock bassrock requested a review from a team as a code owner November 28, 2023 22:19
@bassrock bassrock requested review from jpetto, Herraj and kschelonka and removed request for a team, jpetto and Herraj November 28, 2023 22:19
Copy link

@anthony-liddle anthony-liddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise this looks good

@bassrock bassrock merged commit 8892837 into main Nov 28, 2023
4 checks passed
@bassrock bassrock deleted the allowNoNameRds branch November 28, 2023 22:57
pocket-ci pushed a commit that referenced this pull request Nov 28, 2023
## [5.2.1](v5.2.0...v5.2.1) (2023-11-28)

### Bug Fixes

* **rds:** allowing a no name rds ([#1094](#1094)) ([8892837](8892837))
@pocket-ci
Copy link

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bkochendorfer
Copy link
Member

😭

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants