Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a benchmark for Passthrough/cropbox vs a Functer filter version #4837

Open
kunaltyagi opened this issue Jul 6, 2021 · 5 comments
Open
Labels
good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue module: benchmarks module: filters

Comments

@kunaltyagi
Copy link
Member

Passthrough/cropbox vs a Functer filter version

Code is present in the issue, just need to make a PR of that. #4247

Originally posted by @kunaltyagi in #4833 (comment)

@kunaltyagi kunaltyagi added good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue module: benchmarks module: filters labels Jul 6, 2021
@kuspia
Copy link

kuspia commented Aug 18, 2021

I would like to work on this can u guide me

@mvieth
Copy link
Member

mvieth commented Aug 18, 2021

@tin1254 You didn't start working on this yet, did you? At least I did not find anything in your pull requests.
@kuspia Have a look at the code in issue #4247 . We would like a benchmark for the PassThrough filter and a benchmark for the CropBox filter (and benchmarks for the functor filter with the same functionality, but that can be a second step). Additionally, have a look at the PassThrough filter tutorial and at the other benchmarks already implemented in the benchmarks folder. Is that a good starting point for you or do you have any specific questions?

@tin1254
Copy link
Contributor

tin1254 commented Aug 18, 2021

Not yet, I just finished templating the voxel filters benchmark (but i was planning to benchmark the new PassThrough and CropBox soon)

@kuspia
Copy link

kuspia commented Aug 19, 2021

I understood the concern and need for the Functer filter version now please read what I understood, and if you think I am good to go, say to me for creating a PR so that it gets merged, I have worked on PCL APIs to segment out ROI objects from a noisy 2.5D scan but I am a newbie to GitHub contribution so please suggest if I am going in the wrong direction.

I am supposed to create the following files:
benchmarks/filters/crop_box.cpp
benchmarks/filters/pass_through.cpp

The above files will have an apt piece of code for benchmark and after that, I should make the apt modification in benchmarks/CMakeLists.txt

I have following questions in my mind
A) Now If I am done will this mark this issue closed and my PR will get merged successfully
B) Benchmarks for the functor filter with the same functionality will be solved in this issue or some other

@mvieth
Copy link
Member

mvieth commented Aug 19, 2021

@kuspia Maybe it is better and easier if you work on another issue. CropBox and PassThrough are currently being rewritten, and we will see if we actually need additional benchmarks for the functor filter. So the goal of this issue is still a bit fuzzy.
Maybe have a look at the good first issues. I am sure there is something interesting there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Skills/areas of expertise needed to tackle the issue kind: todo Type of issue module: benchmarks module: filters
Projects
None yet
Development

No branches or pull requests

4 participants