-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a benchmark for Passthrough/cropbox vs a Functer filter version #4837
Comments
I would like to work on this can u guide me |
@tin1254 You didn't start working on this yet, did you? At least I did not find anything in your pull requests. |
Not yet, I just finished templating the voxel filters benchmark (but i was planning to benchmark the new |
I understood the concern and need for the Functer filter version now please read what I understood, and if you think I am good to go, say to me for creating a PR so that it gets merged, I have worked on PCL APIs to segment out ROI objects from a noisy 2.5D scan but I am a newbie to GitHub contribution so please suggest if I am going in the wrong direction. I am supposed to create the following files: The above files will have an apt piece of code for benchmark and after that, I should make the apt modification in benchmarks/CMakeLists.txt I have following questions in my mind |
@kuspia Maybe it is better and easier if you work on another issue. CropBox and PassThrough are currently being rewritten, and we will see if we actually need additional benchmarks for the functor filter. So the goal of this issue is still a bit fuzzy. |
Code is present in the issue, just need to make a PR of that. #4247
Originally posted by @kunaltyagi in #4833 (comment)
The text was updated successfully, but these errors were encountered: