Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge FindSSE and FindAVX cmake files #4867

Open
kunaltyagi opened this issue Jul 29, 2021 · 0 comments
Open

Merge FindSSE and FindAVX cmake files #4867

kunaltyagi opened this issue Jul 29, 2021 · 0 comments

Comments

@kunaltyagi
Copy link
Member

A cleaner solution might be to unify pcl_find_sse.cmake and pcl_find_avx.cmake, and have a single variable (e.g. ARCH_FLAGS) that contains sse, avx, and march flags, instead of SSE_FLAGS and AVX_FLAGS. But I would say the current state of this PR still works, and in the interest of getting this merged soon I would propose to not do any major changes here.
I think the cmake options PCL_ENABLE_SSE, PCL_ENABLE_AVX, and PCL_ENABLE_MARCHNATIVE give good control over which flags are added.

Originally posted by @mvieth in #4698 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant