Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[segmentation] "Retrieve differences OR similarities between two point clouds with pcl::SegmentDifferences::segment" #4990

Open
tomcat327 opened this issue Oct 20, 2021 · 2 comments
Labels
kind: request Type of issue status: triage Labels incomplete

Comments

@tomcat327
Copy link

Hello, very easy feature request here, but I'm a person very new to C++ and PCL as well.

Currently, pcl::SegmentDifferences::segment is able to return the portion of the "src" point cloud that differs from the "target" point cloud. I would like there to be an option with this to return the portion of the "src" point cloud that is similar to the "target" point cloud.

I believe that besides adding a boolean for the user to set that determines whether we're doing difference or similar, the only line that would need to change is this one:
image

The new line would be something like
if ((nn_distances[0] > threshold && !getSimiliarInsteadFlag) || (nn_distances[0] < threshold && getSimiliarInsteadFlag))

Thank you!

@tomcat327 tomcat327 added kind: request Type of issue status: triage Labels incomplete labels Oct 20, 2021
@mvieth
Copy link
Member

mvieth commented Oct 22, 2021

We maintainers likely don't have the time right now to work on this, but you are of course welcome to do so and submit a pull request.
Just a hint though, the class CorrespondenceEstimation in the registration module does approximately what you are describing

@daohu527
Copy link
Contributor

daohu527 commented Sep 1, 2023

@mvieth @tomcat327 Although this issue has been pending for a long time, here are 2 possible solutions

  • provide a new interface that returns similar and difference point clouds
  • also return difference indexes, and leave the rest to the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: request Type of issue status: triage Labels incomplete
Projects
None yet
Development

No branches or pull requests

3 participants