fix(icon)-replaced pluscircle icon with > #2431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chayandass <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@MaxGhenis , can you please check this pr , and give some review on it ? |
|
I'll handle the review for this one. I'll do so tomorrow, worst-case Wednesday. |
anth-volk
reviewed
Mar 27, 2025
There was a problem hiding this comment.
@ChayanDass Thank you for your work on this. I'm going to seek some clarification from Max in the issue itself, because as I look at your implementation (thanks for the screenshot!), I'm thinking this might actually be confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2418
Description
Replaced the
PlusCircleOutlinedicon with the>icon in theNetIncomeBreakdown.jsxfile for better visual clarity and consistency with the design guidelines.Changes
PlusCircleOutlinedicon.>icon usingCaretRightOutlinedfrom@ant-design/icons.Screenshots
Tests