Prefer import statements in tests

Polymer-Japan · Dec 6, 2018 · fb2f294 · fb2f294
1 parent 55e8a89
commit fb2f294
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/test/unit/counter-element.html b/test/unit/counter-element.html
@@ -16,13 +16,9 @@
     <meta name="viewport" content="width=device-width, initial-scale=1">
 
     <script src="../../node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js"></script>
-    <script src="../../node_modules/@polymer/test-fixture/test-fixture.js"></script>
     <script src="../../node_modules/chai/chai.js"></script>
     <script src="../../node_modules/mocha/mocha.js"></script>
     <script src="../../node_modules/wct-mocha/wct-mocha.js"></script>
-
-    <!-- Import the element to test -->
-    <script type="module" src="../../src/components/counter-element.js"></script>
   </head>
   <body>
     <test-fixture id="basic">
@@ -32,8 +28,10 @@
     </test-fixture>
 
     <script type="module">
+      import '@polymer/test-fixture';
       import 'axe-core/axe.min.js';
       import {axeReport} from 'pwa-helpers/axe-report.js';
+      import '../../src/components/counter-element.js';
 
       suite('counter-element tests', function() {
         let el;

diff --git a/test/unit/views-a11y.html b/test/unit/views-a11y.html
@@ -22,15 +22,8 @@
     </script>
 
     <script src="../../node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js"></script>
-    <script src="../../node_modules/@polymer/test-fixture/test-fixture.js"></script>
     <script src="../../node_modules/mocha/mocha.js"></script>
     <script src="../../node_modules/wct-mocha/wct-mocha.js"></script>
-
-    <!-- Import the element to test -->
-    <script type="module" src="../../src/components/my-view1.js"></script>
-    <script type="module" src="../../src/components/my-view2.js"></script>
-    <script type="module" src="../../src/components/my-view3.js"></script>
-    <script type="module" src="../../src/components/my-view404.js"></script>
   </head>
   <body>
     <test-fixture id="view1">
@@ -55,8 +48,13 @@
     </test-fixture>
 
     <script type="module">
+      import '@polymer/test-fixture';
       import 'axe-core/axe.min.js';
       import {axeReport} from 'pwa-helpers/axe-report.js';
+      import '../../src/components/my-view1.js';
+      import '../../src/components/my-view2.js';
+      import '../../src/components/my-view3.js';
+      import '../../src/components/my-view404.js';
 
       suite('views a11y tests', function() {
         test('my-view1', function() {