Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent resizable fails to receive resize notification when under shadow DOM. #32

Open
1 of 8 tasks
n1ywb opened this issue Jun 29, 2017 · 3 comments
Open
1 of 8 tasks

Comments

@n1ywb
Copy link

n1ywb commented Jun 29, 2017

Description

Parent resizables fail to receive resize notification when under shadow DOM.

Commenting out this line fixes the issue: https://github.com/PolymerElements/iron-resizable-behavior/blob/master/iron-resizable-behavior.html#L136

See also PolymerElements/paper-menu-button#123

Shady DOM event call tree

Shady DOM event call tree

Shadow DOM event call tree; note lack of call to _onDescendantIronResize()

Shadow DOM event call tree; note lack of call to _onDescendantIronResize()

Expected outcome

The menu dropdown should resize to accommodate the submenu when the submenu is opened

Expected result

image

Actual outcome

The menu does not resize and is super skinny and fubar

image

Live Demo

https://readingplus.github.io/paper-menu-sizing-bug/components/paper-menu-sizing-bug/demo/index.html?dom=shadow

Steps to reproduce

  1. open demo using shadow DOM
  2. click on menu button
  3. click on submenu

Note that if you leave the submenu opened, close the menu, then reopen the menu, it will then resize to accommodate the submenu; this is, however, annoying to have to do.

Browsers Affected

  • Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@n1ywb
Copy link
Author

n1ywb commented Jun 29, 2017

Looks like this patch might be related to this issue: DreamworldSolutions@b246ff3

@RoXuS
Copy link

RoXuS commented Sep 13, 2017

👍

An other example of the issue -> http://jsbin.com/codakapiwu/edit?html,console,output

@n1ywb
Copy link
Author

n1ywb commented Aug 21, 2018

Folks there's been a PR sitting in here for a year to fix this bug; can we get it merged? @notwaldorf can you help us out with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants