Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

neon-animation doesn't work in Polymer 2.0 #154

Closed
7 tasks
johnlim opened this issue Aug 19, 2017 · 7 comments
Closed
7 tasks

neon-animation doesn't work in Polymer 2.0 #154

johnlim opened this issue Aug 19, 2017 · 7 comments

Comments

@johnlim
Copy link

johnlim commented Aug 19, 2017

Description

In paper-dialog V2.0.0, setting entry-animation results in the following console errors

    at HTMLElement.configure (slide-from-bottom-animation.html:42)
    at HTMLElement._configureAnimations (neon-animation-runner-behavior.html:33)
    at HTMLElement.playAnimation (neon-animation-runner-behavior.html:93)
    at HTMLElement._renderOpened (paper-dialog.html:98)
    at HTMLElement.__openedChanged (iron-overlay-behavior.html:541)
    at nextAnimationFrame (iron-overlay-behavior.html:566)

Expected outcome

Should show animation without error

Actual outcome

No animation is shown and there are console errors

Live Demo

https://jsbin.com/guditofini/edit?html,console,output
pls open chrome dev console to see the error displayed.

Browsers Affected

  • [x ] Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@web-padawan
Copy link

Have you included web-animations-lite.min.js? AFAIK you should do it for 2.0

@johnlim
Copy link
Author

johnlim commented Aug 19, 2017

@web-padawan Thanks! Adding

<script src="https://cdnjs.cloudflare.com/ajax/libs/web-animations/2.2.1/web-animations-next.min.js"></script>

made it work. However, where is the information to add web-animations-lite.min.js located? It wasn't immediately clear to me that this was a requirement. Thanks :)

@web-padawan
Copy link

@johnlim you need to import this file

@valdrinkoshi
Copy link
Member

Info available in the README.md

neon-animation 2.0 doesn't import the Web Animations polyfill, so you'll have to import it
<link rel="import" href="../neon-animation/web-animations.html">

@johnlim
Copy link
Author

johnlim commented Aug 20, 2017

@web-padawan @valdrinkoshi Thanks!

@WillieCubed
Copy link

Isn't neon-animation deprecated, though? What are the plans for this?

@valdrinkoshi
Copy link
Member

The plan is to replace these animations with more standard platform's animation APIs 👌
See this blog post for more details https://www.polymer-project.org/blog/2017-07-12-an-update-on-neon-animation.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants