feat: 🎸 allow multiSig signers to submit proposals #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polymath-eric
force-pushed
the
multi-proc
branch
4 times, most recently
from
de9205b
to
d118a51
Compare
polymath-eric
commented
Aug 6, 2024
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const optionType = (options as any).type; | ||
|
|
||
| const extendsQueueModel = optionType.prototype instanceof TransactionQueueModel; |
There was a problem hiding this comment.
This instanceof check made for a circular dependency, which moving to its own file resolved.
polymath-eric
force-pushed
the
multi-proc
branch
2 times, most recently
from
4fc2790
to
281fe90
Compare
polymath-eric
requested review from
VictorVicente,
prashantasdeveloper and
sansan
as code owners
polymath-eric
force-pushed
the
multi-proc
branch
from
281fe90
to
37cd91f
Compare
When a multiSig signer submits a transaction it will be wrapped and a `proposal` field will be present in the response (or `multiSig` field present will be in offline payloads)
polymath-eric
force-pushed
the
multi-proc
branch
from
37cd91f
to
aac249b
Compare
|
sansan
approved these changes
Aug 13, 2024
|
🎉 This PR is included in version 5.5.0-alpha.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Link
DA-1252
Changelog / Description
When a multiSig signer submits a transaction it will be wrapped and a
proposalfield will be present in the response (ormultiSigfield present will be in offline payloads)Checklist -