From 81a08dd25278f868067e607ba0e62c169cd6186b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C9=91rry=20Shiv=C9=91m?= <touka.krs@gmail.com>
Date: Fri, 21 Jun 2024 12:19:26 +0530
Subject: [PATCH] fix: Fix line height of texts in classic goal item (#146)

Signed-off-by: starry-shivam <starry@krsh.dev>
---
 .idea/deploymentTargetSelector.xml                     |  4 ++--
 .../ui/screens/home/composables/GoalItems.kt           |  4 ++--
 .../ui/screens/welcome/composables/WelcomeScreen.kt    | 10 +++++++---
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/.idea/deploymentTargetSelector.xml b/.idea/deploymentTargetSelector.xml
index 0a7216e..251f6f1 100644
--- a/.idea/deploymentTargetSelector.xml
+++ b/.idea/deploymentTargetSelector.xml
@@ -4,10 +4,10 @@
     <selectionStates>
       <SelectionState runConfigName="app">
         <option name="selectionMode" value="DROPDOWN" />
-        <DropdownSelection timestamp="2024-06-11T06:18:06.972983824Z">
+        <DropdownSelection timestamp="2024-06-21T06:24:05.747252212Z">
           <Target type="DEFAULT_BOOT">
             <handle>
-              <DeviceId pluginId="LocalEmulator" identifier="path=/home/starry/.android/avd/Pixel_3a_API_34.avd" />
+              <DeviceId pluginId="PhysicalDevice" identifier="serial=685adbce" />
             </handle>
           </Target>
         </DropdownSelection>
diff --git a/app/src/main/java/com/starry/greenstash/ui/screens/home/composables/GoalItems.kt b/app/src/main/java/com/starry/greenstash/ui/screens/home/composables/GoalItems.kt
index 9f61528..85e4a4f 100644
--- a/app/src/main/java/com/starry/greenstash/ui/screens/home/composables/GoalItems.kt
+++ b/app/src/main/java/com/starry/greenstash/ui/screens/home/composables/GoalItems.kt
@@ -151,7 +151,7 @@ fun GoalItemClassic(
                 Text(
                     text = primaryText,
                     modifier = Modifier.padding(start = 8.dp, top = 6.dp),
-                    lineHeight = 1.2f.em,
+                    lineHeight = 1.25f.em,
                     fontSize = 14.sp,
                     fontFamily = greenstashFont,
                     color = MaterialTheme.colorScheme.onSurface
@@ -159,7 +159,7 @@ fun GoalItemClassic(
                 Text(
                     text = secondaryText,
                     modifier = Modifier.padding(start = 8.dp, top = 8.dp),
-                    lineHeight = 1.1f.em,
+                    lineHeight = 1.3f.em,
                     fontSize = 14.sp,
                     fontFamily = greenstashFont,
                     color = MaterialTheme.colorScheme.onSurface
diff --git a/app/src/main/java/com/starry/greenstash/ui/screens/welcome/composables/WelcomeScreen.kt b/app/src/main/java/com/starry/greenstash/ui/screens/welcome/composables/WelcomeScreen.kt
index a0b1525..8a1327c 100644
--- a/app/src/main/java/com/starry/greenstash/ui/screens/welcome/composables/WelcomeScreen.kt
+++ b/app/src/main/java/com/starry/greenstash/ui/screens/welcome/composables/WelcomeScreen.kt
@@ -52,6 +52,7 @@ import androidx.compose.runtime.remember
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.platform.LocalView
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.text.style.TextAlign
@@ -71,10 +72,12 @@ import com.starry.greenstash.ui.common.SlideInAnimatedContainer
 import com.starry.greenstash.ui.navigation.DrawerScreens
 import com.starry.greenstash.ui.screens.welcome.WelcomeViewModel
 import com.starry.greenstash.ui.theme.greenstashFont
+import com.starry.greenstash.utils.weakHapticFeedback
 
 
 @Composable
 fun WelcomeScreen(navController: NavController) {
+    val view = LocalView.current
     val context = LocalContext.current
     val viewModel: WelcomeViewModel = hiltViewModel()
 
@@ -142,7 +145,7 @@ fun WelcomeScreen(navController: NavController) {
                 OutlinedButton(
                     onClick = { currencyDialog.value = true },
                     modifier = Modifier
-                        .width(230.dp)
+                        .width(245.dp)
                         .animateContentSize(),
                     shape = RoundedCornerShape(16.dp),
                 ) {
@@ -158,11 +161,12 @@ fun WelcomeScreen(navController: NavController) {
 
                 FilledTonalButton(
                     onClick = {
+                        view.weakHapticFeedback()
                         viewModel.saveOnBoardingState(completed = true)
                         navController.popBackStack()
                         navController.navigate(DrawerScreens.Home.route)
                     },
-                    modifier = Modifier.width(230.dp),
+                    modifier = Modifier.width(245.dp),
                     shape = RoundedCornerShape(16.dp)
                 ) {
                     Text(
@@ -174,7 +178,7 @@ fun WelcomeScreen(navController: NavController) {
             }
         }
 
-        Spacer(modifier = Modifier.height(24.dp))
+        Spacer(modifier = Modifier.height(34.dp))
 
         CurrencyPicker(
             defaultCurrencyValue = viewModel.getDefaultCurrencyValue()