Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log not store name of device as JSON #125

Closed
PoorRican opened this issue May 6, 2023 · 1 comment · Fixed by #207
Closed

Log not store name of device as JSON #125

PoorRican opened this issue May 6, 2023 · 1 comment · Fixed by #207
Labels
question Further information is requested

Comments

@PoorRican
Copy link
Owner

Should Log store name of originating device? More definite identifying devices
@PoorRican PoorRican added the question Further information is requested label May 6, 2023
@PoorRican PoorRican moved this to 🆕 New in 0.1.0-beta Release May 16, 2023
@PoorRican PoorRican moved this from 🆕 New to 👀 In review in 0.1.0-beta Release May 16, 2023
@PoorRican
Copy link
Owner Author

The name field has been removed. Log retains a copy of DeviceMetadata as of #183. See #185 for keeping DeviceMetadata up-to-date.

@PoorRican PoorRican mentioned this issue May 21, 2023
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 0.1.0-beta Release May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
No open projects
0.1.0-beta Release
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log splitting PoorRican/sensd
1 participant
@PoorRican