You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Basically, the provider simply wraps IsFeatureEnabled. During the writing of the provider there were a few things I noticed that I think could be improved and wanted to ask what you thought.
So, these mostly relate to the IsFeatureEnabled method.
The call doesn't error out if the API key is incorrect. It does log "posthog 2023/09/07 15:43:34 ERROR: Error calling /decide/" which is not that useful.
It would be nice if this method returned a boolean.
If the flag doesn't exist we have no way of knowing this and we just get back false. It would be nice to somehow know that the flag doesn't exist.
Every request logs "posthog 2023/09/07 15:04:36 ERROR: Unable to fetch feature flags%!(EXTRA )", but I am not sure why.
Not exactly related to IsFeatureEnabled, but if I simply specify a non-empty personal API key when constructing the client, this request succeeds. So is the personal API key actually required?
Thank you for your time! If there are some things you think we can improve I would be happy to try to create a PR.
The text was updated successfully, but these errors were encountered:
👋 Hello!
I am trying out PostHog, and I wanted to use PostHog feature flags via OpenFeature, so I wrote a PostHog provider for OpenFeature. (You can find it https://github.com/craigpastro/posthog-openfeature-provider-go if you are interested 🙂 )
Basically, the provider simply wraps
IsFeatureEnabled
. During the writing of the provider there were a few things I noticed that I think could be improved and wanted to ask what you thought.So, these mostly relate to the
IsFeatureEnabled
method.IsFeatureEnabled
, but if I simply specify a non-empty personal API key when constructing the client, this request succeeds. So is the personal API key actually required?Thank you for your time! If there are some things you think we can improve I would be happy to try to create a PR.
The text was updated successfully, but these errors were encountered: