Skip to content

Commit 6a6b18c

Browse files
authored
Upgrade development dependencies (#41)
All of the dev dependencies were super outdated and the tests wouldn't work.
1 parent c88b369 commit 6a6b18c

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

lib/posthog/feature_flags.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def self.relative_date_parse_for_feature_flag_matching(value)
229229
# Guard against overflow, disallow numbers greater than 10_000
230230
return nil
231231
end
232-
232+
233233
interval = match[2]
234234
if interval == "h"
235235
parsed_dt = parsed_dt - (number/24r)
@@ -254,7 +254,7 @@ def self.relative_date_parse_for_feature_flag_matching(value)
254254
def self.match_property(property, property_values)
255255
# only looks for matches where key exists in property_values
256256
# doesn't support operator is_not_set
257-
257+
258258
PostHog::Utils.symbolize_keys! property
259259
PostHog::Utils.symbolize_keys! property_values
260260

@@ -436,7 +436,7 @@ def is_condition_match(flag, distinct_id, condition, properties)
436436
if !rollout_percentage.nil? and _hash(flag[:key], distinct_id) > (rollout_percentage.to_f/100)
437437
return false
438438
end
439-
439+
440440
return true
441441
end
442442

@@ -531,6 +531,6 @@ def _request(uri, request_object)
531531
logger.debug("Unable to complete request to #{uri}")
532532
throw e
533533
end
534-
end
534+
end
535535
end
536536
end

posthog-ruby.gemspec

+6-6
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,19 @@ Gem::Specification.new do |spec|
1414
spec.homepage = 'https://github.com/PostHog/posthog-ruby'
1515
spec.license = 'MIT'
1616
spec.required_ruby_version = '>= 2.0'
17-
17+
1818
spec.add_dependency 'concurrent-ruby', '~> 1'
1919

2020
# Used in the executable testing script
2121
spec.add_development_dependency 'commander', '~> 4.4'
2222

2323
# Used in specs
24-
spec.add_development_dependency 'rake', '~> 10.3'
25-
spec.add_development_dependency 'rspec', '~> 3.0'
26-
spec.add_development_dependency 'tzinfo', '1.2.1'
27-
spec.add_development_dependency 'activesupport', '~> 4.1.11'
24+
spec.add_development_dependency 'rake', '~> 13.1'
25+
spec.add_development_dependency 'rspec', '~> 3.13'
26+
spec.add_development_dependency 'tzinfo', '~> 2.0'
27+
spec.add_development_dependency 'activesupport', '~> 7.1'
2828
if RUBY_VERSION >= '2.0' && RUBY_PLATFORM != 'java'
29-
spec.add_development_dependency 'oj', '~> 3.6.2'
29+
spec.add_development_dependency 'oj', '~> 3.16.3'
3030
end
3131
if RUBY_VERSION >= '2.1'
3232
spec.add_development_dependency 'rubocop', '~> 0.51.0'

spec/spec_helper.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
end
88

99
require 'posthog'
10-
require 'active_support/time'
10+
require 'active_support/all'
1111
require 'webmock/rspec'
1212

1313
# Setting timezone for ActiveSupport::TimeWithZone to UTC

0 commit comments

Comments
 (0)