ClickHouse driver used in plugin-server is outdated #11616
Description
@macobo reported that adding comments to ClickHouse queries seems to cause the query to fail. This seems like the same issue as reported here: apla/node-clickhouse#54
Overall, the larger problem is that we use an unmaintained fork of an old unmaintained driver. This is a problem that is bound to get worse over time. Staying behind like this may lead us to obscure bugs in the future as well as missing out on features, performance improvements, and security updates.
Immediately I thought to migrate us to the more established driver these days: https://github.com/TimonKK/clickhouse and began the work to do so. However, the project is also a bit unpolished, and is lacking particularly on the typing front, which makes it more likely for us to have bugs.
I think here we have a few options:
- Fork https://github.com/TimonKK/clickhouse and:
a. Just do what we need to do and effectively postpone this problem
b. Choose to take this very seriously and chose to ship improvements and maintain the library in a way that puts it as the top driver choice in the Node ecosystem. This is probably a nice lil' thing we can do for the community but would require some effort on our end - Contribute back to https://github.com/TimonKK/clickhouse and see if we can ship improvements to it fast enough
- Just use https://github.com/TimonKK/clickhouse as is
- Improve our current fork and maintain that more actively (options 1a and 1b also apply here)
- Do nothing at all
I think option 2 might be worth it and I'll try to get the ball rolling immediately. Maybe we consider 1b in the future...