Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] handle Vision 9.7 GUID in a different way #248

Open
petersalemink95 opened this issue Apr 25, 2024 · 1 comment
Open

[FEATURE] handle Vision 9.7 GUID in a different way #248

petersalemink95 opened this issue Apr 25, 2024 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@petersalemink95
Copy link
Member

Vision 9.7 introduced GUID instead of Number/Subnumber as identification of objects.

Currently we handle these new Vision excels by internally converting the GUID kolom to a Number/Subnumber. This way the users can still use the old yaml files. The issue with this is that users of Vision 9.7 still need to have Number/Subnumber within their mapping files, even though they have never heard of these name. We need to implement the handling of GUID in a more meaningful way, without magic happening in the backend

@petersalemink95 petersalemink95 added the feature New feature or request label Apr 25, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Apr 26, 2024
@Jerry-Jinfeng-Guo
Copy link
Contributor

Quick proposal:

In the yaml configuration files, make the key field something like:

key:
  - Number
  - GUID

Users can leave this as is or remove one of them if they are certain. Internally, we do not do magic check on behalf user for GUID and instead crash on bad input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants