Skip to content

Conversation

@dberna2
Copy link
Contributor

@dberna2 dberna2 commented Sep 27, 2025

This PR fixes the diff view to display all line numbers on both sides, even when a line has no content.

Previously, only the existing line numbers were rendered (e.g., only 4 was shown on the right), which made the comparison harder to follow.

Before
image

After
image

Now, both contexts display the same number of lines, keeping the numbering aligned and making it easier to visually compare differences.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dberna2
Copy link
Contributor Author

dberna2 commented Sep 30, 2025

Hi @rieckpil

I've noticed that the Sonar check is failing on this log request.
However, I haven't found anything in the new code that appears to violate the coding style or quality standards.
Do you know if any of the Sonar standards have changed recently, or if there's any other reason why the scan might be failing?

@rieckpil
Copy link
Contributor

rieckpil commented Oct 1, 2025

thanks for this convenient fix, @dberna2! I haven't had a detailed look into the Sonar settings yet, so I'm happy to merge and adopt later.

@rieckpil rieckpil merged commit 0b58519 into PragmaTech-GmbH:main Oct 1, 2025
1 check failed
@dberna2 dberna2 deleted the fix/align-line-numbers-in-diff-view branch October 2, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants