-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(YummyAnime): add activity #10356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
@gnice225 If you need help to implement the timestamp settings send me DM in discord: _xdoritos I would be glad to help you, if you want obviously! |
Co-authored-by: Skully <117316808+skullysmods@users.noreply.github.com> Signed-off-by: Nikita Radcenko <127035335+gnice225@users.noreply.github.com>
Thank you, but for now I'm trying to figure it out myself to better understand how it works. |
Co-authored-by: Daniel Lau <32113157+theusaf@users.noreply.github.com> Signed-off-by: Nikita Radcenko <127035335+gnice225@users.noreply.github.com>
Co-Authored-By: Nikita Radcenko <127035335+gnice225@users.noreply.github.com>
Co-Authored-By: Nikita Radcenko <127035335+gnice225@users.noreply.github.com>
|
Resolve: #10230 |
|
@skullysmods @theusaf, PR is ready for review |
skullysmods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
websites/Y/YummyAnime/metadata.json
Outdated
| "description": { | ||
| "en": "Displays anime you are watching on YummyAnime." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to get a better description? Any official one?
websites/Y/YummyAnime/metadata.json
Outdated
| "category": "anime", | ||
| "tags": ["anime", "video"], | ||
| "iframe": true, | ||
| "iFrameRegExp": "kodik" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats not really a regex, expand it a little.
Co-authored-by: Bas van Zanten <bas.van.zanten007@gmail.com> Signed-off-by: ch1ka <164895536+ch1kulya@users.noreply.github.com>
Head branch was pushed to by a user without write access
Signed-off-by: ch1ka <164895536+ch1kulya@users.noreply.github.com>
Signed-off-by: ch1ka <164895536+ch1kulya@users.noreply.github.com>
|
@Bas950, thanks for the review! I have fixed everything you asked for |
Description
Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected