Skip to content

[3.x] Keep referenced body fields when a request body schema adds sibling properties - #5441

Closed
jlowin wants to merge 2 commits into
release/3.xfrom
fix/openapi-body-ref-siblings-3.x
Closed

jlowin wants to merge 2 commits into
release/3.xfrom
fix/openapi-body-ref-siblings-3.x

Conversation

@jlowin

@jlowin jlowin commented Oct 4, 2026

Copy link
Copy Markdown
Member

A request body schema written as a $ref with sibling properties (valid in OpenAPI 3.1) now exposes the referenced schema's properties and required fields together with the sibling properties, and sends all of them in the request body. Previously the tool advertised only the sibling properties, so fields defined by the referenced schema could not be passed. Sibling properties take precedence when both define the same name; bodies that are a plain $ref are unchanged.

Backports the change from main.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T15:13:39.949398Z 769b0fe PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@marvin-context-protocol marvin-context-protocol Bot added bug Something isn't working. Reports of errors, unexpected behavior, or broken functionality. openapi Related to OpenAPI integration, parsing, or code generation features. v3 Targeted for FastMCP 3 labels Oct 4, 2026
@jlowin jlowin closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. Reports of errors, unexpected behavior, or broken functionality. openapi Related to OpenAPI integration, parsing, or code generation features. v3 Targeted for FastMCP 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants