implement textDocument/completion in editor API

[Prince781]

API: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_completion

[Prince781]

@aitor-gomila I've assigned this to you because it's necessary and simple enough to implement, so it should help you understand the codebase.

[Prince781]

I've already implemented the data types for this API. You just need to add logic in the Editor class for receiving completions. We don't currently use progress tokens so don't worry about that.

[Prince781]

Another thing to remember: notifications result in signal events being dispatched to the editor, while requests must be asynchronous methods that return the server's result. textDocument/completion is a request.

[ghost]

How do I implement this?

[Prince781]

@aitor-gomila broadly, add a method to the Editor class that allows you to request completion items for a certain document at a certain position. Here's what the signature should probably look like:

public async CompletionItem[]? completion_async(Uri uri, Position position,
                                                CompletionTriggerKind = CompletionTriggerKind.UNSET) {
   // ...
}

These types come from the API I linked in the first comment. Feel free to ask me more questions, but try to read the API I linked and look at the surrounding code to get an understanding on your own.

I'm not sure your level of experience. I don't want to overwhelm you, so if you want we could do live coding in the Vala discord.

[ghost]

Hi! Sorry for not answering. I have been busy with other stuff lately.

I will start working on this issue soon. Do you have discord/telegram/whatever so we can communicate more fluently? I think it's a good practice to use GitHub issues for most important things, but maybe for questions it's best to use something else :)

[Prince781]

No problem. Work at your own pace. And yes, the Vala discord is linked in that comment.