-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid virtual casing #214
Closed
missing-user
wants to merge
40
commits into
PrincetonUniversity:master
from
missing-user:grid-virtual-casing
Closed
Grid virtual casing #214
missing-user
wants to merge
40
commits into
PrincetonUniversity:master
from
missing-user:grid-virtual-casing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ca2313.
* Add Flowchart to repository, fix URLs in README * added .ext.sp.DF and ext.sp.end to grp_output * added .GF.ma and .GF.ev files to grp_output * added SPEC flowchart to doxygen * added SPEC flowchart to doxygen * reverted Doxygen action name change * Add link to SPEC wiki for cluster installation instructions * Revert "Add link to SPEC wiki for cluster installation instructions" This reverts commit 0ca2313. * Contributors citation file added * Changed preferred citation format to the first SPEC paper * added verification paper to references * use Citations.cff in readme * updated and validated cff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #32
I iteratively increase the resolution to get an estimate of how well the integral has converged, and could adaptively refine the grid until a given epsilon is reached. For now it just prints the error estimate and doesn't terminate if gBnstol isn't reached.
For the rotating ellipse test case at a given accuracy, it is approximately 10x faster than the current implementation.
Possible improvements