Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid virtual casing #214

Closed

Conversation

missing-user
Copy link
Contributor

@missing-user missing-user commented Nov 29, 2024

Addressing issue #32
I iteratively increase the resolution to get an estimate of how well the integral has converged, and could adaptively refine the grid until a given epsilon is reached. For now it just prints the error estimate and doesn't terminate if gBnstol isn't reached.

For the rotating ellipse test case at a given accuracy, it is approximately 10x faster than the current implementation.

Possible improvements

  • Interpolate the precomputed surface currents when performing the integration, to have an "even finer grid" or possibly use an adaptive integration routine ontop of the interpolated values as @lazersos suggested.
  • Possibly reuse the computed surface currents across multiple vc iterations, and only recompute the outer integral with the $1/r^2$ term.
  • Add test cases comparing the implementations

missing-user and others added 30 commits November 15, 2024 00:32
* Add Flowchart to repository, fix URLs in README

* added .ext.sp.DF and ext.sp.end to grp_output

* added .GF.ma and .GF.ev files to grp_output

* added SPEC flowchart to doxygen

* added SPEC flowchart to doxygen

* reverted Doxygen action name change

* Add link to SPEC wiki for cluster installation instructions

* Revert "Add link to SPEC wiki for cluster installation instructions"

This reverts commit 0ca2313.

* Contributors citation file added

* Changed preferred citation format to the first SPEC paper

* added verification paper to references

* use Citations.cff in readme

* updated and validated cff
@missing-user missing-user marked this pull request as draft November 29, 2024 22:33
@missing-user missing-user marked this pull request as ready for review December 3, 2024 13:08
@missing-user missing-user marked this pull request as draft December 3, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant