-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPECFEM++ (v0.1.0) #101
Merged
Merged
SPECFEM++ (v0.1.0) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression testing
- Shared pointer implementation - Shared pointer implementations for 1. solver 2. writer 3. materials 4. sources 5. receivers - This should improve memory safety - TODO: move qudrature to separate class and MPI to a shared_ptr - This will be a major change - There are still memory safety issues when running large number of tests using ctest with intel compiler. The current workaround is to explicitly run displacement test individually - Eventually I want to make the code memory safe using shared_ptr. i.e. complete the TODO above.
- For composite boundaries : - partial derivatives need to be loaded when the boundary_tag == composite_stacey_dirichlet
- updated to cudatoolkit/12.2 - using della module boost/1.73.0 for intel compilation/unittests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First major release of SPECFEM++ (v0.1.0)
New Features
GLL Library
Meshing (MESHFEM)
Sources
Source time function
Receiver
Physics
Boundary Conditions
Solver
Known Issues
Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.