Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement kernels #104

Merged
merged 9 commits into from
Feb 21, 2024
Merged

Reimplement kernels #104

merged 9 commits into from
Feb 21, 2024

Conversation

Rohit-Kakodkar
Copy link
Collaborator

Description

Please describe the changes/features in this pull request.

This PR reimplements element, sources and receiver kernels for the newer assembly formulation

  • Major changes
    • element, source, receiver classes are now exclusive method classes. This is a pre-cursor to replacing element, source and receiver classes to templated functions. This will simplify the interface.
    • Coupled interfaces are templated on medium types and not on domains. Simplifies the interface.

Issue Number

If there is an issue created for these changes, link it here

Checklist

Please make sure to check developer documentation on specfem docs.

[x] I ran the code through pre-commit to check style
[] My code passes all the integration tests
[x] I have added sufficient unittests to test my changes
[x] I have added/updated documentation for the changes I am proposing
[x] I have updated CMakeLists to ensure my code builds
[x] My code builds across all platforms

@Rohit-Kakodkar
Copy link
Collaborator Author

Does not compile on GPUs.

@Rohit-Kakodkar Rohit-Kakodkar merged commit 434da58 into Assembly-refactor Feb 21, 2024
3 of 6 checks passed
@Rohit-Kakodkar Rohit-Kakodkar deleted the reimplement-kernels branch February 21, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant