dG Dependencies: iteration policy, edge accessor #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
+ added specfem::edge::index to be similar to specfem::point::index + chunk_edge policy now uses View<specfem::edge::index> instead of two separate views for ispec and edge::type = modified test accordingly
|
test this please |
+ compatibility with devel merge + chunk_edge test is now templated for medium + accessor_tests now load a mesh database - removed build_demo_assembly
|
retest this please |
lsawade
approved these changes
Feb 24, 2025
| }; | ||
| } // namespace iterator | ||
|
|
||
| // TODO all above this is same as chunk.hpp |
| return iterator_type(my_indices, ngll); | ||
| } | ||
|
|
||
| private: |
icui
approved these changes
Feb 26, 2025
Rohit-Kakodkar
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the changes/features in this pull request.
Note: instead of merging to devel, consider a push to a different issue branch dedicated to dG dependencies
Adds the following to stage for merging dG into SPECFEM++:
chunk_edgeteam policy (each edge iterates ngll nodes along that edge)chunk_edgefield accessorspecfem::compute::load_on_...routines forchunk_edgeWe additionally create an
accessorunit test directory, which could also be shared withpoint,chunk_element, etc. in the future. As for now,pointfields are "tested" to validate thechunk_edgeteam policy.Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.