Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 398 - Implement dynamic testing #464

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Issue 398 - Implement dynamic testing #464

merged 6 commits into from
Feb 14, 2025

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Feb 10, 2025

Description

  • This mainly implements a couple of compilation presets using CMakePresets.json. Currently supported presets are debug and release, which both are the serial+SIMD presets. I will add more as I continue working on the 3D mesh reader.
  • To make the presets work, the tests needed some work. That means all test now expect to be run from ./tests/unit-test as defined using a WORKING_DIRECTORY in the gtest_discover section in the tests/unit-tests/CMakeLists.txt
    • All file locations that are used in the tests have thus been updated removing the ../../../tests/unit-tests/ prefix
    • To make sure that IO tests write in the output binary directory a compiler definition TEST_OUTPUT_DIR has been added. It is mainly the property reader and writer that are using this mechanism.
    • written files are being removed at the end of the testing cycle.

There are a few intermediate commits for the fortran reading that are insignificant.

Issue Number

closes #398
closes #450

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade lsawade requested a review from icui February 10, 2025 22:13
@lsawade lsawade merged commit 3a02a2b into issue-390 Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants