dG Dependecies: Mesh Modifiers and Subdivision

[int-ptr-ptr]

Description

Please describe the changes/features in this pull request.

This PR adds a mesh-modifiers tree to the specfem parameters, as well as its first entry: subdivisions, which allow for modifying specfem::mesh::mesh by subdividing elements corresponding to a specific material. Upon the introduction of LCIs, a mesh-modifiers.coupling entry will allow the user to specify how to resolve interfaces (strongly coupled / loosely coupled, what flux scheme, etc.), but for now, if adjacent materials have nonconforming subdivisions, the code should error out.

Going forward, mesh-modifiers should add a new step to the execute() pipeline, where, after reading in a specfem::mesh:mesh instance, a modifiers.apply(&mesh) call would augment the mesh before being passed into the constructor of specfem::compute::assembly.

Issue Number

If there is an issue created for these changes, link it here

Checklist

*Please make sure to check developer documentation on specfem docs. *

• I ran the code through pre-commit to check style
• My code passes all the integration tests
• I have added sufficient unittests to test my changes
• I have added/updated documentation for the changes I am proposing
• I have updated CMakeLists to ensure my code builds
• My code builds across all platforms

[buildbot-princeton]

Can one of the admins verify this patch?

[buildbot-princeton]

Can one of the admins verify this patch?

[buildbot-princeton]

Can one of the admins verify this patch?

[Rohit-Kakodkar]

ok to test

[lsawade]

Your RTD fix is merged into devel. Can you merge devel into this, please?

[lsawade]

Is this working, or work in progress? I'm asking because it looks like everything's there.

If it is working could you add an example to the examples directory? Could be a next PR.

[int-ptr-ptr]

Is this working, or work in progress? I'm asking because it looks like everything's there.

If it is working could you add an example to the examples directory? Could be a next PR.

When I talked with Rohit, he said that this and the other dG PR would probably go into a separate dG branch until it's feature complete enough to go into devel.

[lsawade]

When I talked with Rohit, he said that this and the other dG PR would probably go into a separate dG branch until it's feature complete enough to go into devel.

That sounds good to me. You could follow the setup we have for, e.g., the reading of the 3D Mesh, #476 , or Performance optimizations #488

That is you could change the base branch you merge into to #220 for example, unless that one is stale!

[lsawade]

Ooops, reviews this a bit ago but forgot to submit the review...

LGTM