Issue 484/498/499/500 -- Implements reading of ispec_is_<medium>, materials, and mass matrices. #501
Conversation
|
I think I should already be organizing my materials, element_types, etc. in a more meaning full way using the something that resembles the assembly more closely. That is better use of the medium_tags. I will work in a refactor at the end of this once everything is read correctly. |
|
I didn't merge the most recent update yet so the file updates were longer than they should have been. I update the PR to only reflect files from after the merge. |
Fix for readthedocs build failing
| @@ -221,10 +257,17 @@ subroutine save_arrays_solver_mesh() | |||
| ! write(IOUT) kappastore | |||
| ! write(IOUT) mustore | |||
|
|
|||
| write(IOUT) | |||
|
|
|||
| ! Converting the logical arrays to integer arrays and writing them as ints | |||
There was a problem hiding this comment.
Is this supposed to be commented? Should we store a single array with different ints depending on the domain type?
There was a problem hiding this comment.
Was just following your lead, the arrays are being stored using the save_global_arrays:
call save_global_arrays(nspec, xixstore)
call save_global_arrays(nspec, xiystore)
call save_global_arrays(nspec, xizstore)
call save_global_arrays(nspec, etaxstore)
call save_global_arrays(nspec, etaystore)
call save_global_arrays(nspec, etazstore)
call save_global_arrays(nspec, gammaxstore)
call save_global_arrays(nspec, gammaystore)
call save_global_arrays(nspec, gammazstore)
call save_global_arrays(nspec, jacobianstore)
! write test value
itest = 10000
write(IOUT) itest
! write(IOUT) xixstore
! write(IOUT) xiystore
! write(IOUT) xizstore
! write(IOUT) etaxstore
! write(IOUT) etaystore
! write(IOUT) etazstore
! write(IOUT) gammaxstore
! write(IOUT) gammaystore
! write(IOUT) gammazstore
! write(IOUT) jacobianstore
call save_global_arrays(nspec, kappastore)
call save_global_arrays(nspec, mustore)
! write(IOUT) kappastore
! write(IOUT) mustore| @@ -57,11 +57,6 @@ void specfem::IO::mesh::impl::fortran::dim3::read_array(std::ifstream &stream, | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Can you add doc strings for these functions in utilities.hpp
There was a problem hiding this comment.
Yes, I hadn't yet because these kept on changing as aI was debugging! Will add doc strings!
|
|
||
| template <specfem::element::medium_tag MediumTag> View1D<int> get_elements(); | ||
|
|
||
| void print() const; |
There was a problem hiding this comment.
What do these print functions do? Can you add doc strings?
There was a problem hiding this comment.
Yes I need to add doc strings to everything!
| type_real kappa_min = std::numeric_limits<type_real>::max(); | ||
| type_real kappa_max = std::numeric_limits<type_real>::lowest(); | ||
|
|
||
| Kokkos::parallel_reduce( |
There was a problem hiding this comment.
These parallel_reduce kernels need to run on the Host space. The views kappa is a host view.
There was a problem hiding this comment.
whoops, forgot about le execution_space
Description
Implements
Issue Number
closes #484
Closes #498
closes #499
closes #500
Checklist
Please make sure to check developer documentation on specfem docs.