Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 504 - Implement the reading of coupled interfaces. #505

Merged
merged 15 commits into from
Feb 25, 2025
Merged

Issue 504 - Implement the reading of coupled interfaces. #505

merged 15 commits into from
Feb 25, 2025

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Feb 21, 2025

Description

Implemented:

  • struct to hold all coupled interfaces
  • implemented medium_tag1/2 implemented holders for coupled_interfaces
  • implemented reading of arrays related to coupled interfaces.

Issue Number

closes #504

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

lsawade and others added 14 commits February 18, 2025 14:30
Rohit-Kakodkar
Rohit-Kakodkar approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just comments from previous PRs. Otherwise LGTM!

@lsawade lsawade requested a review from icui February 24, 2025 18:18
@lsawade lsawade merged commit 71665b9 into issue-390 Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rohit-Kakodkar Rohit-Kakodkar Rohit-Kakodkar approved these changes

@icui icui Awaiting requested review from icui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsawade @Rohit-Kakodkar @int-ptr-ptr