Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elastic shear wave enumerations #507

Open
wants to merge 3 commits into
base: issue-491
Choose a base branch
from
Open

Conversation

Rohit-Kakodkar
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar commented Feb 24, 2025

Description

Adds elastic_sh tag to medium_tag enumerations

  • Updates medium.hpp and material_definitions.hpp to include elastic_sh enumeration
  • Updates medium_tag specific methods within enumerations

Issue Number

closes #495

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

- Updates medium.hpp and material_definitions.hpp to include elastic_sh enumeration
- Updates medium_tag specific methods within enumerations
Copy link
Collaborator

@lsawade lsawade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohit-Kakodkar
Copy link
Collaborator Author

@icui can you take a look at this when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants