refactor point_properties and property_container #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that computing the derived properties on the fly instead of storing them has no performance impact, probably we should use this implementation instead. |
| using Base::Base; | ||
| constexpr static int _counter = __COUNTER__; | ||
|
|
||
| DEFINE_CONTAINER(rho_inverse) |
| : public impl::impl_properties_container< | ||
| specfem::element::medium_tag::acoustic, | ||
| specfem::element::property_tag::isotropic, 2> { | ||
| using Base = |
There was a problem hiding this comment.
can we use base_type here.
| template <specfem::element::medium_tag MediumTag, | ||
| specfem::element::property_tag PropertyTag, int N> | ||
| struct impl_properties_container { | ||
| using view_type = typename Kokkos::View<type_real ****, Kokkos::LayoutLeft, |
There was a problem hiding this comment.
I think view type shoudl be Kokkos::View<type_real ***[N], Kokkos::LayoutLeft, ...> since we know the value of N at compile time.
lsawade
approved these changes
Feb 26, 2025
| DEFINE_PROP(c12) ///< @f$ c_{12} @f$ | ||
| DEFINE_PROP(c23) ///< @f$ c_{23} @f$ | ||
| DEFINE_PROP(c25) ///< @f$ c_{25} @f$ | ||
| DEFINE_PROP(rho) ///< Density @f$ \rho @f$ |
There was a problem hiding this comment.
So Counter works, because at each first property use you store its value and subtract it. Neat.
| using Base::Base; | ||
| constexpr static int _counter = __COUNTER__; | ||
|
|
||
| DEFINE_CONTAINER(rho_inverse) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
point_property.mu()rho_vp) are now computed on the flyIssue Number
Closes #489
Checklist
Please make sure to check developer documentation on specfem docs.