-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 506 - Addressing comments on previous few commits #510
Open
lsawade
wants to merge
43
commits into
issue-390
Choose a base branch
from
issue-506
base: issue-390
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,623
−2,175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for readthedocs build failing
Add function to access field of a medium
…he reading of the mesh arrays
…ed buuild/html added, added doc strings and examples to fortran/IO and mesh/dim3 reading utilities with examples
…to the headers and its underlines.
…ameter docuemtnation
… materials, mesh,
Rohit-Kakodkar
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix typo in impl_store_on_device.
…pes to read integer arrays plus the first update for printing correcltuy
6 tasks
Final commit fixed the NVIDIA compiler bug highlighted in #476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cosmetic changes to both code and documentation. See #506 for a full list of tasks/adjustments
.rst
files. Until now doxygen is always run whenever you build the documentation. This should be the standard behavior. But when you are just editing the RST files and not the actual source files it causes the source xmls to be rebuilt every single time. And sphinx needs to reread the files even though nothing has changed. you can now setexport NODOXYGEN=1
make
wizard.kokkos::parallel_reduce
loop to find min/maxkappa
andmu
to run onhost executionspace
.Issue Number
closes #506
Checklist
Please make sure to check developer documentation on specfem docs.