Composite boundaries #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements composite boundary conditions for stacey-dirichlet type. Compile and run tests to see the failing tests.
This commit unifies rmass_inverse tests for elastic and acoustic domains inside within a single run program - similar to how displacement tests are done. This should make it easy to add more add more tests using test-config.yaml
- Composite BCs are implemented as a combition of multiple BCs
- This type calls the underlying methods for the combining BCs
for example -
composite_boundary<stacey, dirichlet>.method{stacey.method; dirichlet.method}
- This should let define the BCs in a very modular way
- Code compiles and passes tests
- Composite BCs are of O(1) elements for 2D and O(N) for 3D. Hence, these kernels should be launched first in the queue, to utilize GPU parallelism
Extensive documentation for all the BCs that are implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements composite boundaries for corner elements. Composite boundaries are implemented as variadic templated class which call the underlying boundaries.
Implementation details
The templated types could be any of 2 or more boundary conditions. The methods for this class call the underlying BC implementation for enforcing the BCs.
Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.