Code along #97
Merged
Code along #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements composite boundary conditions for stacey-dirichlet type. Compile and run tests to see the failing tests.
This commit updates instances of SPECFEM2d, SPECFEM, SPECFEM2D Kokkos refering to the current package to SPECFEM++ which is consistent with the name update
This commit results in more stable jenkins builds by generating new build folder name for every commit - Updates groovy scripts to use commit numbers - Updates reopsitory name
Updates repository name to SPECFEM++
This reverts commit 714644886bc4900c16c6ad3e80caa746c950bccf.
This commit unifies rmass_inverse tests for elastic and acoustic domains inside within a single run program - similar to how displacement tests are done. This should make it easy to add more add more tests using test-config.yaml
- Composite BCs are implemented as a combition of multiple BCs
- This type calls the underlying methods for the combining BCs
for example -
composite_boundary<stacey, dirichlet>.method{stacey.method; dirichlet.method}
- This should let define the BCs in a very modular way
- Code compiles and passes tests
- Composite BCs are of O(1) elements for 2D and O(N) for 3D. Hence, these kernels should be launched first in the queue, to utilize GPU parallelism
Extensive documentation for all the BCs that are implemented.
Composite boundaries
- Added explicit reference to value_t rather than using a static class member - The latter wouldnt compile on GPU - Problems with composite BC on GPU - Removed tests related to composite BCs for now - The release candidate will have this bug which I plan to patch before releasing the actual tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the changes/features in this pull request.
Merges contributions for acoustic domain implementations and (stacey/dirichlet) boundaries.
Changes in domain implementation
Added separate boundary condition classes
Issue Number
If there is an issue created for these changes, link it here
Checklist
Please make sure to check developer documentation on specfem docs.