Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix heldItemChanged was not fired in all cases when the held item was changed #3392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Jun 6, 2024

it should not be in set_slot event, it should be updated whenever the slot is actually updated (e.g. by inventory manipulation)

@zardoy zardoy changed the title fix: Fix heldItemChanged was not fired in all cases when the held item is changed fix: Fix heldItemChanged was not fired in all cases when the held item was changed Jun 6, 2024
@rom1504
Copy link
Member

rom1504 commented Jun 9, 2024

If this is correct, please add a test to check what is not working before this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for user input
Development

Successfully merging this pull request may close these issues.

2 participants