-
-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use dimension data on 1.16.2 #3397
base: master
Are you sure you want to change the base?
Conversation
tests are passing locally and I can't scroll to the error on the github (seems logs are too large)... |
@@ -261,7 +261,7 @@ function inject (bot, { version, storageBuilder, hideErrors }) { | |||
bot.world.setColumn(packet.chunkX, packet.chunkZ, column) | |||
} | |||
|
|||
if (bot.supportFeature('dimensionDataIsAvailable')) { | |||
if (bot.supportFeature('newLightingDataFormat')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for 1.17 https://github.com/PrismarineJS/minecraft-data/blob/8a8c811c71790d75ec405429e5b50343cb77f88b/data/pc/common/features.json#L785
that contradicts the PR description
which is right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that contradicts the PR description
Didn't say anything about this change in the pr description, but this change is correct: loadParsedLight
is available starting from 1.17 (new lighting format)
What user input does it wait for? |
dimension packet is available starting from 1.16.2
finishing PrismarineJS/minecraft-data#877