1.21.6#3713
Conversation
|
seems remaining failures are pretty trivial. Should be fixable by just asking a coding agent to run the test and fix for a while; if someone want to try |
|
Looks like issue with entity metadata Mineflayer line https://github.com/PrismarineJS/mineflayer/blob/master/lib/plugins/entities.js#L449-L476 |
|
Fixed above by using 1.21.5 entities data (1.21.6 is missing entity metadata inside entities.json, but nothing actually changes in .6) Next server crashes when decoding player chat command packet. This is preceded by this write This could be a serialization issue, or a logical error in chat checksum computation or issue with acknowledgments |
- Update elytra flying to use string mapping 'start_elytra_flying' for 1.21.6+ - Update sprint actions to use string mappings for 1.21.6+ - Move sneak handling to player_input packet for 1.21.6+ - Maintain backward compatibility with older versions using feature detection Fixes compatibility with Minecraft 1.21.6 protocol changes where: - entity_action packets now use string mappers instead of numeric IDs - sneak functionality moved from entity_action to player_input packet Co-authored-by: Claude <noreply@anthropic.com>
|
claude fixed elytra, only fishing needs fixing now |
|
remaining issue is about fishing_bobber not being detected
could be related to this |
|
ah I see, mcdata has "entities": "pc/1.21.5", |
we need this fixed |
|
PrismarineJS/minecraft-data#1028 I guess there are some issues with metadata there |
|
we need some test/schema validating we have entity metadata in mcdata. Maybe something you can help with @ItsDrike |
|
one way to fix is to take the metadata keys from 1.21.5 and port them to 1.21.6 file https://github.com/PrismarineJS/minecraft-data/blob/master/data/pc/1.21.5/entities.json |
|
another way would be checking what is wrong there https://github.com/PrismarineJS/minecraft-data-generator/blob/main/mc/1.21.6/src/main/java/dev/u9g/minecraftdatagenerator/generators/EntitiesDataGenerator.java |
|
seemed you added metadata keys for 1.21.5 in https://github.com/PrismarineJS/minecraft-data/pull/1029/files @extremeheat do you remember what you ran? |
|
Yeah, there's a script to generate in mcdata (tools/js/extractPcEntityMetadata.js), I updated with |
|
some tests still timeout but I wonder if it's the added logging causing it |
As in enforcing the presence of Versions missing
|
that's the next thing to fix |
|
well also there are these partial read errors |
yeah makes sense. Maybe we could enforce it only in PC and starting at version 1.19.4 |
This should be possible, but again, wrapper changes would be required for the type generation as this would mean multiple schemas for different versions. Or do you just want to skip the tests for this key missing on the older versions? That would work, but it's kind of hacky and the schema would be lying then. Also, skipping is annoying since it means no validation for that particular schema at all for the ignored versions, it's not trivial to only skip if a certain specific error occurred and not for multiple errors. I did skip validation in this way for one version as an exception in PrismarineJS/minecraft-data#1056, but even that was done with the expectation that the tints data will be added later on, and fairly soon. |
Add logging
|
That test for the field can be separate from the schema tests. From the data consumer standpoint you have to treat it as conditional because the data may or may not exist on some versions. From data generation standpoint since it's just a script to run to generate we can add it as part of the automated PR generation process |
|
|
||
| function teamHandler (packet) { | ||
| const { team: teamName, mode } = packet | ||
| console.log("team.packet", packet) |
|
For the errors it would probably be a good idea to figure out how to retry on failure with debug packet logging enabled. Without it it's a lot harder to debug / diff changes between versions. Maybe we could even have a script to auto post specific test debug mode diffs |
I think we can probably just have a try catch in the common of external test, but we'd need to do the beforeEach logic manually without mocha |
|
Nice everything passing Still got to fix these partial read errors though. |
This reverts commit 0518d08.
|
/makerelease |
3 participants
PrismarineJS/node-minecraft-protocol#1416