Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to pick up on line-broken address' (such as in Twitter bio) #13

Open
outragedhuman opened this issue Jan 7, 2017 · 2 comments
Labels
Milestone

Comments

@outragedhuman
Copy link

I've noticed that the app doesn't seem to pick up on Twitter Bio address', and I'm suspecting it's due to the line break. This might be a tricky fix, but Twitter would be one of the biggest places that I would be picking up on addy's so it would be very nice if it could see them.

Example:

image

@Leo-ajc
Copy link
Collaborator

Leo-ajc commented Jan 11, 2017

Ah yeah, Twitter. Yes, I think it might be the line break. We have had it work on Twitter before, but Twitter is particularly difficult because of all the dynamically loaded content.

If this is not related to the line break, I think it could be related to dynamically loaded content. I was working on attaching a re-search feature on the dynamic loading hook. I remember I had trouble, then I had to take up a new job, which sucked my time away.

I'll see if I can dig up my old branch where I tested out the re-search function.

@outragedhuman
Copy link
Author

Sounds good. I'll keep an eye out, if I see an addy without a break in it I'll let you know if it picks up on that one.

@bnvk bnvk added the bug label Mar 5, 2018
@bnvk bnvk added this to the Rebooted milestone Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants